fix(builtins): clear variable on read at EOF with no remaining data#976
Merged
fix(builtins): clear variable on read at EOF with no remaining data#976
Conversation
When read reaches EOF and there is no partial line data remaining, clear the target variable to empty string before returning 1. This prevents the common `while read line || [[ -n "$line" ]]` pattern from looping infinitely on the stale last value. Closes #953
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readat EOF retaining the last value instead of clearing the variablewhile read line || [[ -n "$line" ]]pattern from infinite loopingWhat
The
readbuiltin returnedExecResult::err("", 1)on EOF without anySetVariableside effects, so the variable kept its previous value. Now the EOF path parses flag arguments first, then emitsSetVariableside effects with empty values for all target variables.Test plan
read_eof_clears_variable— verifiesprintf "one\ntwo"loop terminatesread_eof_partial_line— verifies partial line without trailing newline is capturedCloses #953